Skip to content

Comments

service: clarify docs around shared resource consumption in poll_ready()#662

Merged
hawkw merged 1 commit intotower-rs:masterfrom
mattklein123:poll-ready-docs
Jun 10, 2022
Merged

service: clarify docs around shared resource consumption in poll_ready()#662
hawkw merged 1 commit intotower-rs:masterfrom
mattklein123:poll-ready-docs

Conversation

@mattklein123
Copy link
Contributor

@mattklein123 mattklein123 commented May 27, 2022

Signed-off-by: Matt Klein [email protected]

@mattklein123 mattklein123 mentioned this pull request May 27, 2022
Open
hawkw
hawkw approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, thanks!

@hawkw hawkw merged commit 8b52292 into tower-rs:master Jun 10, 2022
@mattklein123 mattklein123 deleted the poll-ready-docs branch June 11, 2022 02:38
hawkw pushed a commit that referenced this pull request Jun 17, 2022
@mattklein123 @hawkw
service: clarify docs around shared resource consumption in poll_read…
697b8d0 
…y() (#662)

Signed-off-by: Matt Klein <[email protected]>
@hawkw hawkw mentioned this pull request Jun 17, 2022
Merged
hawkw pushed a commit that referenced this pull request Jun 17, 2022
@mattklein123 @hawkw
service: clarify docs around shared resource consumption in poll_read…
0feb182 
…y() (#662)

Signed-off-by: Matt Klein <[email protected]>
hawkw added a commit that referenced this pull request Jun 17, 2022
@hawkw
chore: prepare to release tower-service v0.3.2
e3ecfaf 
# Unreleased

- None

# 0.3.2 (June 17, 2022)

## Added

- **docs**: Clarify subtlety around cloning and readiness in the
  `Service` docs ([#548])
- **docs**: Clarify details around shared resource consumption in
  `poll_ready()` ([#662])

[#548]: #548
[#662]: #662
@hawkw hawkw mentioned this pull request Jun 17, 2022
Merged
hawkw added a commit that referenced this pull request Jun 17, 2022
@hawkw
chore: prepare to release tower-service v0.3.2 (#673)
04527ae 
# 0.3.2 (June 17, 2022)

## Added

- **docs**: Clarify subtlety around cloning and readiness in the
  `Service` docs ([#548])
- **docs**: Clarify details around shared resource consumption in
  `poll_ready()` ([#662])

[#548]: #548
[#662]: #662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkw hawkw hawkw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattklein123 @hawkw