Merged
Conversation
Added - **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615]) - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the `BoxService` and `CloneBoxService` middleware ([#616]) - **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for applying `BoxService` and `CloneBoxService` layers ([#616]) Fixed - **balance**: Remove redundant `Req: Clone` bound from `Clone` impls for `MakeBalance`, and `MakeBalanceLayer` ([#607]) - **balance**: Remove redundant `Req: Debug` bound from `Debug` impls for `MakeBalance`, `MakeFuture`, `Balance`, and `Pool` ([#607]) - **ready-cache**: Remove redundant `Req: Debug` bound from `Debug` impl for `ReadyCache` ([#607]) - **steer**: Remove redundant `Req: Debug` bound from `Debug` impl for `Steer` ([#607]) - **util**: Remove redundant `F: Clone` bound from `ServiceExt::map_request` ([#607]) - **docs**: Fix `doc(cfg(...))` attributes of `PeakEwmaDiscover`, and `PendingRequestsDiscover` ([#610]) - **util**: Remove unnecessary `Debug` bounds from `impl Debug for BoxService` ([#617]) - **util**: Remove unnecessary `Debug` bounds from `impl Debug for UnsyncBoxService` ([#617]) [#607]: #607 [#610]: #610 [#616]: #616 [#617]: #617 [#615]: #615
davidpdrsn
requested review from
hawkw and
olix0r
and removed request for
hawkw
olix0r
approved these changes
Nov 18, 2021
tower/CHANGELOG.md
Outdated
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the | ||
| `BoxService` and `CloneBoxService` middleware ([#616]) | ||
| - **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for | ||
| applying `BoxService` and `CloneBoxService` layers ([#616]) |
Collaborator
There was a problem hiding this comment.
I know I should have spotted this in #616, but let me revive the naming question before a release goes out... I think think should be called BoxCloneService (and helper should be boxed_clone). My reasoning is that this makes the type/method names lexically grouped (i.e in documentation or tab completion). When searching I'll see all the Box*Services together.
We can defer this to 0.5, though, I guess, since CloneBoxService is similar to UnsyncBoxService...
Member
Author
There was a problem hiding this comment.
@hawkw wondered about that too. I don't feel strongly about it, so think I'll just rename it in this PR.
Collaborator
There was a problem hiding this comment.
I think the change notes need to be updated as well, now...
Collaborator
There was a problem hiding this comment.
Suggested change
| applying `BoxService` and `CloneBoxService` layers ([#616]) | |
| applying `BoxService` and `BoxCloneService` layers ([#616]) |
Member
Author
There was a problem hiding this comment.
whoops! Was a bit too quick with the search and replace. Fixed it!
olix0r
reviewed
Nov 18, 2021
tower/CHANGELOG.md
Outdated
|
|
||
| - **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615]) | ||
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the | ||
| `BoxService` and `CloneBoxService` middleware ([#616]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| `BoxService` and `CloneBoxService` middleware ([#616]) | |
| `BoxService` and `BoxCloneService` middleware ([#616]) |
tower/CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615]) | |
| - **util**: Add `BoxCloneService` which is a `Clone + Send` boxed `Service` ([#615]) |
tower/CHANGELOG.md
Outdated
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the | ||
| `BoxService` and `CloneBoxService` middleware ([#616]) | ||
| - **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for | ||
| applying `BoxService` and `CloneBoxService` layers ([#616]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| applying `BoxService` and `CloneBoxService` layers ([#616]) | |
| applying `BoxService` and `BoxCloneService` layers ([#616]) |
tower/CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615]) | ||
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the |
Collaborator
There was a problem hiding this comment.
Suggested change
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the | |
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::boxed_clone` for applying the |
tower/CHANGELOG.md
Outdated
| - **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615]) | ||
| - **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the | ||
| `BoxService` and `CloneBoxService` middleware ([#616]) | ||
| - **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for |
Collaborator
There was a problem hiding this comment.
Suggested change
| - **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for | |
| - **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::boxed_clone` for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
BoxCloneServicewhich is aClone + SendboxedService(#615)ServiceExt::boxedandServiceExt::boxed_clonefor applying theBoxServiceandBoxCloneServicemiddleware (#616)ServiceBuilder::boxedandServiceBuilder::boxed_cloneforapplying
BoxServiceandBoxCloneServicelayers (#616)Fixed
F: Clonebound fromServiceExt::map_request(#607)Debugbounds fromimpl Debug for BoxService(#617)Debugbounds fromimpl Debug for UnsyncBoxService(#617)Req: Clonebound fromCloneimplsfor
MakeBalance, andMakeBalanceLayer(#607)Req: Debugbound fromDebugimplsfor
MakeBalance,MakeFuture,Balance, andPool(#607)Req: Debugbound fromDebugimplfor
ReadyCache(#607)Req: Debugbound fromDebugimplfor
Steer(#607)doc(cfg(...))attributesof
PeakEwmaDiscover, andPendingRequestsDiscover(#610)