Skip to content

Implement Layer for ServiceBuilder#600

Merged
davidpdrsn merged 1 commit intomasterfrom
builder-layer
Sep 3, 2021
Merged

Implement Layer for ServiceBuilder#600
davidpdrsn merged 1 commit intomasterfrom
builder-layer

Conversation

@davidpdrsn
Copy link
Member

@jonhoo from discord:

I may feel silly for asking this, but why doesn't ServiceBuilder implement Layer?
Like, it has into_inner, but why is the indirection required?

I have wondered the same thing. It compiles and seems sensible to me.

Copy link
Collaborator

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@davidpdrsn davidpdrsn merged commit d91c0f5 into master Sep 3, 2021
@davidpdrsn davidpdrsn deleted the builder-layer branch September 3, 2021 16:54
davidpdrsn added a commit that referenced this pull request Oct 13, 2021
- Migrate to pin-project-lite ([#595])
- **builder**: Implement `Layer` for `ServiceBuilder` ([#600])
- **builder**: Add `ServiceBuilder::and_then` analogous to
  `ServiceExt::and_then` ([#601])

[#600]: #600
[#601]: #601
[#595]: #595
[pin-project-lite]: https://crates.io/crates/pin-project-lite
davidpdrsn added a commit that referenced this pull request Oct 14, 2021
- Migrate to pin-project-lite ([#595])
- **builder**: Implement `Layer` for `ServiceBuilder` ([#600])
- **builder**: Add `ServiceBuilder::and_then` analogous to
  `ServiceExt::and_then` ([#601])

[#600]: #600
[#601]: #601
[#595]: #595
[pin-project-lite]: https://crates.io/crates/pin-project-lite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants