spawn-ready: Abort background tasks when the service is dropped#581
Merged
olix0r merged 6 commits intotower-rs:masterfrom Apr 27, 2021
Merged
spawn-ready: Abort background tasks when the service is dropped#581olix0r merged 6 commits intotower-rs:masterfrom
olix0r merged 6 commits intotower-rs:masterfrom
Conversation
The `SpawnReady` service spawns a background task whenever the inner service is not ready; but when the `SpawnReady` service is dropped, this task continues to run until it becomes ready (at which point the ready service will be dropped). This can cause resource leaks when the inner service never becomes ready. This change adds a `Drop` implementation for the `SpawnReady` service that aborts the background task when appropriate.
davidpdrsn
approved these changes
Apr 27, 2021
hawkw
approved these changes
Apr 27, 2021
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
lgtm, modulo one note about where the test ought to go.
Signed-off-by: Eliza Weisman <[email protected]>
move abort_on_drop test to tests/spawn_ready
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Apr 27, 2021
# 0.4.7 (April 27, 2021)
### Added
- **builder**: Add `ServiceBuilder::check_service` to check the request,
response, and error types of the output service. ([#576])
- **builder**: Add `ServiceBuilder::check_service_clone` to check the
output service can be cloned. ([#576])
### Fixed
- **spawn_ready**: Abort spawned background tasks when the `SpawnReady`
service is dropped, fixing a potential task/resource leak (#[581])
- Fixed broken documentation links ([#578])
[#576]: #576
[#578]: #578
[#581]: #581
hawkw
added a commit
that referenced
this pull request
Apr 27, 2021
# 0.4.7 (April 27, 2021)
### Added
- **builder**: Add `ServiceBuilder::check_service` to check the request,
response, and error types of the output service. ([#576])
- **builder**: Add `ServiceBuilder::check_service_clone` to check the
output service can be cloned. ([#576])
### Fixed
- **spawn_ready**: Abort spawned background tasks when the `SpawnReady`
service is dropped, fixing a potential task/resource leak (#[581])
- Fixed broken documentation links ([#578])
[#576]: #576
[#578]: #578
[#581]: #581
hawkw
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Apr 27, 2021
This updates `tower` to v0.4.7. This picks up tower-rs/tower#581, which fixes a task leak in `SpawnReady` that resulted in a memory leak in the proxy.
olix0r
pushed a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Apr 28, 2021
This updates `tower` to v0.4.7. This picks up tower-rs/tower#581, which fixes a task leak in `SpawnReady` that resulted in a memory leak in the proxy.
olix0r
pushed a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Apr 29, 2021
This updates `tower` to v0.4.7. This picks up tower-rs/tower#581, which fixes a task leak in `SpawnReady` that resulted in a memory leak in the proxy.
olix0r
pushed a commit
to linkerd/drain-rs
that referenced
this pull request
Jun 3, 2021
This updates `tower` to v0.4.7. This picks up tower-rs/tower#581, which fixes a task leak in `SpawnReady` that resulted in a memory leak in the proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SpawnReadyservice spawns a background task whenever the innerservice is not ready; but when the
SpawnReadyservice is dropped, thistask continues to run until it becomes ready (at which point the ready
service will be dropped). This can cause resource leaks when the inner
service never becomes ready.
This change adds a
Dropimplementation for theSpawnReadyservicethat aborts the background task when appropriate.