Rename ServiceExt::ready_and to ServiceExt::ready#567
Merged
Conversation
davidbarsky
requested review from
a team,
davidpdrsn,
hawkw,
jonhoo and
olix0r
Member
let's go ahead and do this, please — that way, we can land this now, and remove |
davidpdrsn
approved these changes
Feb 24, 2021
Member
davidpdrsn
left a comment
davidpdrsn
left a comment
There was a problem hiding this comment.
Yes! I've also thought that ready_and was an awkward name.
Contributor
Author
Done! I've also opened #568 as a reminder. |
jonhoo
approved these changes
Feb 24, 2021
hawkw
requested changes
Feb 24, 2021
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
couple of nits --- can we fix the new warnings added in this PR? i think the other ones were already present, so we can fix those in a follow-up, but this adds new deprecation warnings due to internal use of deprecated APIs.
besides that, lgtm!
Co-authored-by: Eliza Weisman <[email protected]>
hawkw
approved these changes
Feb 25, 2021
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
looks good to me — thanks for fixing the internal deprecation warnings!
hawkw
added a commit
that referenced
this pull request
Feb 27, 2021
Deprecated - **util**: Deprecated `ServiceExt::ready_and` (renamed to `ServiceExt::ready`). ([#567]) - **util**: Deprecated `ReadyAnd` future (renamed to `Ready`). ([#567]) Added - **builder**: Add `ServiceBuilder::layer_fn` to add a layer built from a function. ([#560]) - **builder**: Add `ServiceBuilder::map_future` for transforming the futures produced by a service. ([#559]) - **builder**: Add `ServiceBuilder::service_fn` for applying `Layer`s to an async function using `util::service_fn`. ([#564]) - **util**: Add example for `service_fn`. ([#563]) - **util**: Add `BoxLayer` for creating boxed `Layer` trait objects. ([#569]) [#567]: #567 [#560]: #560 [#559]: #559 [#564]: #564 [#563]: #563 [#569]: #569
davidpdrsn
pushed a commit
that referenced
this pull request
Feb 27, 2021
Deprecated - **util**: Deprecated `ServiceExt::ready_and` (renamed to `ServiceExt::ready`). ([#567]) - **util**: Deprecated `ReadyAnd` future (renamed to `Ready`). ([#567]) Added - **builder**: Add `ServiceBuilder::layer_fn` to add a layer built from a function. ([#560]) - **builder**: Add `ServiceBuilder::map_future` for transforming the futures produced by a service. ([#559]) - **builder**: Add `ServiceBuilder::service_fn` for applying `Layer`s to an async function using `util::service_fn`. ([#564]) - **util**: Add example for `service_fn`. ([#563]) - **util**: Add `BoxLayer` for creating boxed `Layer` trait objects. ([#569]) [#567]: #567 [#560]: #560 [#559]: #559 [#564]: #564 [#563]: #563 [#569]: #569
hawkw
added a commit
that referenced
this pull request
Mar 1, 2021
Deprecated - **util**: Deprecated `ServiceExt::ready_and` (renamed to `ServiceExt::ready`). ([#567]) - **util**: Deprecated `ReadyAnd` future (renamed to `Ready`). ([#567]) Added - **builder**: Add `ServiceBuilder::layer_fn` to add a layer built from a function. ([#560]) - **builder**: Add `ServiceBuilder::map_future` for transforming the futures produced by a service. ([#559]) - **builder**: Add `ServiceBuilder::service_fn` for applying `Layer`s to an async function using `util::service_fn`. ([#564]) - **util**: Add example for `service_fn`. ([#563]) - **util**: Add `BoxLayer` for creating boxed `Layer` trait objects. ([#569]) [#567]: #567 [#560]: #560 [#559]: #559 [#564]: #564 [#563]: #563 [#569]: #569 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Mar 11, 2022
These was deprecated in #567. In 0.5, we can just remove them entirely.
hawkw
added a commit
that referenced
this pull request
Mar 11, 2022
These was deprecated in #567. In 0.5, we can just remove them entirely.
hawkw
added a commit
that referenced
this pull request
Mar 11, 2022
These were deprecated in #567. In 0.5, we can just remove them entirely. Closes #568 Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames:
ServiceExt::ready_andtoServiceExt::readyReadyAndfuture toReadyServiceExt::readyandReadyAnd.My recollection of the original conversation surrounding the introduction of the
ServiceExt::ready_andcombinator in #427 was that it was meant to be a temporary workaround for the unchainableServiceExt::readycombinator until the next breaking release of the Tower crate. The unchainableServiceExt::readycombinator was removed, butServiceExt::ready_andwas not renamed. I believe, but am not 100% sure, that this was an oversight.I also recognize that this PR might have a large impact. To reduce the impact, I'd be happy to modify this PR to introduce
ServiceExt::readyand deprecateServiceExt::ready_and.