Repository navigation
final tweaks - #1
Merged
totallyzen merged 1 commit intoFeb 6, 2024
Merged
Conversation
alexanderankin
force-pushed
the
poetry-refactor
branch
from
February 6, 2024 01:14
a4fec27 to
bf526d0
Compare
mdelapenya
reviewed
Feb 6, 2024
| >>> from testcontainers.elasticsearch import ElasticSearchContainer | ||
|
|
||
| >>> with ElasticSearchContainer(f'elasticsearch:8.3.3') as es: | ||
| >>> with ElasticSearchContainer(f'elasticsearch:8.3.3', mem_limit='3G') as es: |
There was a problem hiding this comment.
FYI the project and product is Elasticsearch 😅 , no capital S 😉
Author
There was a problem hiding this comment.
good catch, several things to merge after this it seems, adding to the list
totallyzen
approved these changes
Feb 6, 2024
totallyzen
left a comment
totallyzen
left a comment
Owner
There was a problem hiding this comment.
thanks mate! really appreciate the help! ❤️
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix outstanding items:
twine checkchecks for this)