Overhaul tracker keys: option to disable auth key expiration #988
Merged
josecelano merged 2 commits intotorrust:developfrom Aug 1, 2024
Conversation
…ration When the tracker is running in private mode you can disable checking keys' expiration in the configuration with: ```toml [core] private = false [core.private_mode] check_keys_expiration = true ``` All keys will be valid as long as they exist in the database.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #988 +/- ##
===========================================
- Coverage 76.89% 76.77% -0.13%
===========================================
Files 184 185 +1
Lines 9916 9959 +43
===========================================
+ Hits 7625 7646 +21
- Misses 2291 2313 +22 ☔ View full report in Codecov by Sentry. |
josecelano
force-pushed
the
978-overhaul-tracker-keys-option-to-disable-auth-key-expiration
branch
from
258f732 to
ed40e4a
Compare
The section [core.provate_mode] can be inlcuded in the configration TOML file only if the tracker is running in private mode (`private = true`). This commits adds that validation and makes it possible to add more semantic validations in the future. Semantic validations are validations that depend on more than one value. Like the one added, it could be any other incompatible combination.
josecelano
force-pushed
the
978-overhaul-tracker-keys-option-to-disable-auth-key-expiration
branch
from
ed40e4a to
d7dfc3b
Compare
Member
Author
|
ACK d7dfc3b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the tracker is running in private mode you can disable checking keys' expiration in the configuration with:
All keys will be valid as long as they exist in the database.