Disable TimeoutAcceptor when TSL is enabled#954
Merged
josecelano merged 1 commit intotorrust:developfrom Aug 7, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #954 +/- ##
===========================================
- Coverage 77.14% 77.10% -0.04%
===========================================
Files 185 185
Lines 10058 10063 +5
===========================================
Hits 7759 7759
- Misses 2299 2304 +5 ☔ View full report in Codecov by Sentry. |
da2ce7
approved these changes
Jul 13, 2024
Contributor
|
ACK 38bb7cd |
da2ce7
added a commit
to da2ce7/torrust-tracker
that referenced
this pull request
Jul 13, 2024
38bb7cd feat: disable TimeoutAcceptor when TSL is enabled (Jose Celano) Pull request description: The TimeoutAcceptor es a custom acceptor for Axum that sets a timeput for making a request after openning a connection. It does not work when TSL is enabled. This commit disables it, therefore the app does not have any way to avoid a DDos attacks where clients just open connections without making any request. ACKs for top commit: josecelano: ACK 38bb7cd da2ce7: ACK 38bb7cd Tree-SHA512: 5c46333b7301d7469566df36d8c082ff139e61ff5ade214b6a232b7635f4add0e3a61e4e098e99215306ea2f49c0c5a1d6473777e5282455642f9600c5ac2d4b
The TimeoutAcceptor es a custom acceptor for Axum that sets a timeput for making a request after openning a connection. It does not work when TSL is enabled. This commit disables it, therefore the app does not have any way to avoid a DDos attacks where clients just open connections without making any request.
josecelano
force-pushed
the
disable-time-acceptor-when-tsl-is-enabled
branch
from
38bb7cd to
222fa42
Compare
Member
Author
|
ACK 222fa42 |
Member
Author
I forgot to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TimeoutAcceptor es a custom acceptor for Axum that sets a timeput for making a request after openning a connection.
It does not work when TSL is enabled.
This commit disables it, therefore the app does not have any way to avoid a DDos attacks where clients just open connections without making any request.