Skip to content

Fix vscode settings#95

Merged
da2ce7 merged 1 commit intodevelopfrom
fix-vscode-settings
Oct 9, 2022
Merged

Fix vscode settings#95
da2ce7 merged 1 commit intodevelopfrom
fix-vscode-settings

Conversation

@josecelano
Copy link
Copy Markdown
Member

@josecelano josecelano commented Sep 22, 2022 •
edited by da2ce7
Loading

The VSCode settings added on PR 80 are not working for me:

"[rust]": {
    "editor.defaultFormatter": "matklad.rust-analyzer",
    "editor.formatOnSave": true
},

@da2ce7 edit. Now removed the line.

"[rust]": {
    "editor.formatOnSave": true
},

@josecelano
Copy link
Copy Markdown
Member Author

josecelano commented Sep 22, 2022

hi @da2ce7, using the settings you merged, I get this error:

image

The current name for the extension seems to be rust-lang.rust-analyzer

https://marketplace.visualstudio.com/items?itemName=rust-lang.rust-analyzer

Maybe you wanted to use a forked version?

@josecelano josecelano requested a review from da2ce7 September 22, 2022 16:04
@josecelano josecelano marked this pull request as ready for review September 22, 2022 16:04
@josecelano josecelano force-pushed the fix-vscode-settings branch 2 times, most recently from b30b887 to 60040c3 Compare September 22, 2022 16:09
@da2ce7
Copy link
Copy Markdown
Contributor

da2ce7 commented Sep 22, 2022

@josecelano Maybe we can get rid of the line "editor.defaultFormatter": "rust-lang.rust-analyzer", and it will still work?

@josecelano
Copy link
Copy Markdown
Member Author

josecelano commented Sep 23, 2022

@josecelano Maybe we can get rid of the line "editor.defaultFormatter": "rust-lang.rust-analyzer", and it will still work?

If you install the extension, you should have its configuration in your user settings:

image

This configuration overwrites yours. Which was the reason why mine stopped working.

@da2ce7 da2ce7 force-pushed the fix-vscode-settings branch from 60040c3 to 0672067 Compare October 9, 2022 11:41
@da2ce7 da2ce7 force-pushed the fix-vscode-settings branch from 0672067 to a9df618 Compare October 9, 2022 11:42
@da2ce7
Copy link
Copy Markdown
Contributor

da2ce7 commented Oct 9, 2022

ACK a9df618

@da2ce7 da2ce7 merged commit 7f8f144 into develop Oct 9, 2022
@josecelano josecelano deleted the fix-vscode-settings branch January 16, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

No one assigned

Labels

None yet

Projects

Torrust Solution
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josecelano @da2ce7