Add privacy methods to the TrackerMode enum#871
Merged
josecelano merged 3 commits intotorrust:developfrom May 21, 2024
Merged
Conversation
Member
Author
|
ACK 08179e3 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #871 +/- ##
===========================================
- Coverage 78.83% 78.62% -0.21%
===========================================
Files 170 170
Lines 9394 9419 +25
===========================================
Hits 7406 7406
- Misses 1988 2013 +25 ☔ View full report in Codecov by Sentry. |
The tracker mode can be: - Public (Non-whitelisted) - Listed (Whitelisted) - Private (Non-whitelisted) - PrivateListed (Whitelisted) They should have been two different flags (in my opinion): - Visibility: public or private - Whitelisted: true or false So we would have the same four convinations: - Not whitelisted: - Public - Private - Whitelisted - Public - Private That's a pending refactor. For this commits, the goal is just to align this enum with what we added to the Index so we can use this enum in the Index via the primmitives crate.
josecelano
force-pushed
the
870-align-trackermode-with-index
branch
from
08179e3 to
0c9da2f
Compare
Member
Author
|
ACK 0c9da2f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracker mode can be:
There should have been two different flags (in my opinion):
So we would have the same four combinations:
That's a pending refactor. For this PR, the goal is just to align this enum with what we added to the Index so we can use it in the Index via the primitive crate.
See https://github.com/torrust/torrust-index/blob/develop/src/config.rs#L140-L171