Add timeout for time waiting for the first HTTP tracker request#866
Merged
josecelano merged 1 commit intotorrust:developfrom May 15, 2024
Conversation
…acker request Adds a timeout to the HTTP tracker for the time the server waits for the first request from the client after openning a new HTTP connection. It also adds a tower middleware for timeouts in requests.
Member
Author
|
ACK 23d5e5e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #866 +/- ##
===========================================
+ Coverage 78.82% 78.88% +0.05%
===========================================
Files 170 170
Lines 9398 9395 -3
===========================================
+ Hits 7408 7411 +3
+ Misses 1990 1984 -6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a timeout to the HTTP tracker for the time the server waits for the first request from the client after opening a new HTTP connection.
It also adds a tower middleware for timeouts in requests.
To test the first case, you can open a connection to the API without sending any request with:
After 5 seconds you will see:
The current implementation for the first timeout does not send a 408 Request Timeout message. It seems it is also a common practice.
For advanced manual testing, you can use https://github.com/josecelano/axum-server-timeout