chore:[#674] Tracker Checker: Ouput in JSON#810
Merged
josecelano merged 3 commits intotorrust:developfrom Apr 24, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #810 +/- ##
===========================================
- Coverage 78.93% 78.91% -0.03%
===========================================
Files 162 163 +1
Lines 9186 9186
===========================================
- Hits 7251 7249 -2
- Misses 1935 1937 +2 ☔ View full report in Codecov by Sentry. |
josecelano
requested changes
Apr 24, 2024
Member
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
Hi @ngthhu looks good. Thank you! Just a couple of things.
Fix formatting errors
Output should be only the json
Command:
cargo run --bin tracker_checker -- --config-path "./share/default/config/tracker_checker.json"Output:
Running checks for trackers ...
{
"udp_trackers": [
{
"url": "127.0.0.1:6969",
"status": {
"code": "ok",
"message": ""
}
}
],
"http_trackers": [
{
"url": "http://127.0.0.1:7070/",
"status": {
"code": "ok",
"message": ""
}
}
],
"health_checks": [
{
"url": "http://127.0.0.1:1313/health_check",
"status": {
"code": "ok",
"message": ""
}
}
]
}
Output should not include:
Running checks for trackers ...
You should be able to parse the output as a json. For example:
cargo run --bin tracker_checker -- --config-path "./share/default/config/tracker_checker.json"| jq
Finished `dev` profile [optimized + debuginfo] target(s) in 0.09s
Running `target/debug/tracker_checker --config-path ./share/default/config/tracker_checker.json`
parse error: Invalid numeric literal at line 1, column 8
thread 'main' panicked at library/std/src/io/stdio.rs:1118:9:
failed printing to stdout: Broken pipe (os error 32)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
josecelano
approved these changes
Apr 24, 2024
Contributor
Author
|
Is it good to name a file with a general name like |
Member
Hi @ngthhu, Since it's a small mod and file, I don't see a big problem. In my case, when I read But, I would probably have named them:
pub struct Output {
pub url: String,
pub status: Status,
}
pub struct Status {
pub code: String,
pub message: String,
}Or:
pub struct Result {
pub url: String,
pub status: Status,
}
pub struct Status {
pub code: String,
pub message: String,
} |
Member
|
ACK b27f002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.