Skip to content

Env: Basic VSCode Extension Recommendations and Settings#80

Merged
da2ce7 merged 2 commits intotorrust:developfrom
da2ce7:vscode-recommendations
Sep 21, 2022
Merged

Env: Basic VSCode Extension Recommendations and Settings#80
da2ce7 merged 2 commits intotorrust:developfrom
da2ce7:vscode-recommendations

Conversation

@da2ce7
Copy link
Copy Markdown
Contributor

@da2ce7 da2ce7 commented Sep 9, 2022 •
edited
Loading

Recommendations:

Settings:

  • Workspace Spelling Ignore List
  • Format on save for Rust Code
  • Check with Clippy on Save

@da2ce7 da2ce7 changed the base branch from develop to main September 11, 2022 13:45
@da2ce7 da2ce7 changed the base branch from main to develop September 11, 2022 13:45
@josecelano
Copy link
Copy Markdown
Member

josecelano commented Sep 12, 2022

In my user settings, I have:

"rust-analyzer.checkOnSave.command": "clippy"

That runs: cargo clippy instead of cargo check. Clippy shows you the same errors and warnings as cargo check with extra recommendations.

@da2ce7 da2ce7 force-pushed the vscode-recommendations branch from 14af791 to 98d8ad2 Compare September 21, 2022 13:23
@da2ce7 da2ce7 changed the title Basic vscode extension recommendations and settings. Env: Basic VSCode Extension Recommendations and Settings Sep 21, 2022
@da2ce7 da2ce7 force-pushed the vscode-recommendations branch from 98d8ad2 to 2b294dd Compare September 21, 2022 18:11
@da2ce7
Copy link
Copy Markdown
Contributor Author

da2ce7 commented Sep 21, 2022

ACK 2b294dd

@da2ce7 da2ce7 merged commit 8da9963 into torrust:develop Sep 21, 2022
@josecelano josecelano mentioned this pull request Sep 22, 2022
Merged
da2ce7 added a commit that referenced this pull request Oct 9, 2022
@da2ce7
Merge #95: Fix vscode settings
7f8f144 
a9df618 fix: vscode setting, remove default formatter (Jose Celano)

Pull request description:

  The VSCode settings added on [PR 80](#80) are not working for me:

  ```
  "[rust]": {
      "editor.defaultFormatter": "matklad.rust-analyzer",
      "editor.formatOnSave": true
  },
  ```

  @da2ce7 edit. Now removed the line.

  ```
  "[rust]": {
      "editor.formatOnSave": true
  },
  ```

ACKs for top commit:
  da2ce7:
    ACK a9df618

Tree-SHA512: 8e46357adf3dbe0b3b7eb71fc5d30ff11fc44aeea89c7568db15efe9c24eec26166f94286f8c52f3b62e5dff174ec258b8b4c46266fe38eaba5a73eecfcab9c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Torrust Solution
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@da2ce7 @josecelano