New torrent repository: SkipMap for Peer List#794
Closed
josecelano wants to merge 2 commits intotorrust:developfrom
Closed
New torrent repository: SkipMap for Peer List#794josecelano wants to merge 2 commits intotorrust:developfrom
josecelano wants to merge 2 commits intotorrust:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #794 +/- ##
===========================================
- Coverage 78.15% 77.86% -0.29%
===========================================
Files 159 159
Lines 8857 9001 +144
===========================================
+ Hits 6922 7009 +87
- Misses 1935 1992 +57 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new implementation of the torrent repository, where the peer list for a torrent entry is implemented using a SkipMap instead of a BTreeMap.
The performance is very bad:
Current implementation:
This PR implementation:
I won't merge it because it makes the repository package much more complex.
This implementation uses a lock for the whole torrent entry. SkipMap would be a good choice if different entries in the peer list could be updated in parallel. However, that's not possible with this implementation, and I think it's not possible at all to use nested collections for the torrents and the torrent peer list.