Skip to content

dev: bugfix completed download stat#740

Merged
josecelano merged 1 commit intotorrust:developfrom
da2ce7:20240319_bug_downloaded_stat
Mar 19, 2024
Merged

dev: bugfix completed download stat#740
josecelano merged 1 commit intotorrust:developfrom
da2ce7:20240319_bug_downloaded_stat

Conversation

@da2ce7
Copy link
Copy Markdown
Contributor

@da2ce7 da2ce7 commented Mar 19, 2024

A peer could repetitively announce that it is completed, making the download stat higher. This changes the behavior to check if the event for the peer is not already completed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (18b46df) to head (439821c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #740   +/-   ##
========================================
  Coverage    73.41%   73.41%           
========================================
  Files          144      144           
  Lines         9318     9318           
========================================
  Hits          6841     6841           
  Misses        2477     2477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@josecelano
Copy link
Copy Markdown
Member

ACK 439821c

@josecelano josecelano self-assigned this Mar 19, 2024
@josecelano josecelano added the Bug Incorrect Behavior label Mar 19, 2024
@josecelano josecelano merged commit 66f1635 into torrust:develop Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Incorrect Behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants