Remove duplication in HTTP announce response#585
Closed
josecelano wants to merge 7 commits intotorrust:developfrom
Closed
Remove duplication in HTTP announce response#585josecelano wants to merge 7 commits intotorrust:developfrom
josecelano wants to merge 7 commits intotorrust:developfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #585 +/- ##
===========================================
+ Coverage 80.68% 80.76% +0.08%
===========================================
Files 117 117
Lines 7816 7824 +8
===========================================
+ Hits 6306 6319 +13
+ Misses 1510 1505 -5 ☔ View full report in Codecov by Sentry. |
Member
Author
|
ACK 759594a |
Contributor
|
I've reviewed this version, and it dose not remove much of the duplication that my version removes. Although I prefer your I will rebase my implementation based upon f9fff63 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @da2ce7, this is an alternative for removing duplication from the HTTP announce response.