Remove always-empty peer list in torrent list item#570
Merged
josecelano merged 1 commit intotorrust:developfrom Jan 2, 2024
Merged
Conversation
josecelano
force-pushed
the
536-remove-empty-peer-list-in-api-get-torrents-endpoint
branch
from
c150db7 to
d03e930
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #570 +/- ##
===========================================
- Coverage 79.30% 79.29% -0.01%
===========================================
Files 117 117
Lines 7736 7733 -3
===========================================
- Hits 6135 6132 -3
Misses 1601 1601 ☔ View full report in Codecov by Sentry. |
Member
Author
|
ACK d03e930 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint to get the list of torrents returns a list of items like this:
[ { "info_hash": "0031ad8520ddfebd856d70776063e477eaf07ada", "seeders": 0, "completed": 0, "leechers": 1, "peers": null } ]The
peerslist is alwaysnulleven if there are peers. That's very confusing especially if you enable the config optionremove_peerless_torrents.This PR removes that unused attribute.