Skip to content

Cleanup Service Initialization#561

Merged
da2ce7 merged 1 commit intotorrust:developfrom
da2ce7:20231231_cleanup_service_init
Jan 4, 2024
Merged

Cleanup Service Initialization#561
da2ce7 merged 1 commit intotorrust:developfrom
da2ce7:20231231_cleanup_service_init

Conversation

@da2ce7
Copy link
Copy Markdown
Contributor

@da2ce7 da2ce7 commented Dec 31, 2023

Extracted from:

Closes #560

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 31, 2023 •
edited
Loading

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (051a0c8) 79.25% compared to head (13140f6) 80.68%.

Files Patch % Lines
src/servers/udp/server.rs 81.53% 12 Missing ⚠️
src/bootstrap/jobs/udp_tracker.rs 0.00% 10 Missing ⚠️
src/app.rs 0.00% 7 Missing ⚠️
src/servers/http/server.rs 86.79% 7 Missing ⚠️
src/servers/apis/server.rs 88.46% 6 Missing ⚠️
src/bootstrap/jobs/health_check_api.rs 0.00% 5 Missing ⚠️
src/bootstrap/jobs/http_tracker.rs 83.33% 5 Missing ⚠️
src/bootstrap/jobs/tracker_apis.rs 89.28% 3 Missing ⚠️
src/bootstrap/jobs/mod.rs 95.12% 2 Missing ⚠️
src/core/databases/error.rs 33.33% 2 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
+ Coverage    79.25%   80.68%   +1.43%     
===========================================
  Files          117      117              
  Lines         7711     7816     +105     
===========================================
+ Hits          6111     6306     +195     
+ Misses        1600     1510      -90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@da2ce7 da2ce7 force-pushed the 20231231_cleanup_service_init branch from b53a219 to 108e3b5 Compare December 31, 2023 12:46
@da2ce7 da2ce7 mentioned this pull request Jan 1, 2024
Merged
@josecelano josecelano added the Needs Rebase Base Branch has Incompatibilities label Jan 3, 2024
josecelano
josecelano previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @da2ce7 I've only added a couple of comments. Regarding my comments on configuration it's something to consider for future bif refactors in configuration.

@da2ce7 da2ce7 force-pushed the 20231231_cleanup_service_init branch from 108e3b5 to b6ce640 Compare January 3, 2024 13:28
@da2ce7 da2ce7 mentioned this pull request Jan 3, 2024
Closed
5 tasks
@da2ce7 da2ce7 removed the Needs Rebase Base Branch has Incompatibilities label Jan 3, 2024
@da2ce7 da2ce7 force-pushed the 20231231_cleanup_service_init branch from b6ce640 to a12fdee Compare January 3, 2024 14:29
@josecelano
Copy link
Copy Markdown
Member

josecelano commented Jan 3, 2024

ACK a12fdee

@da2ce7 da2ce7 force-pushed the 20231231_cleanup_service_init branch from a12fdee to 13140f6 Compare January 4, 2024 01:32
@da2ce7
Copy link
Copy Markdown
Contributor Author

da2ce7 commented Jan 4, 2024

ACK 13140f6

@da2ce7 da2ce7 merged commit 5f6eed7 into torrust:develop Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josecelano josecelano josecelano left review comments

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

Assignees

No one assigned

Labels

None yet

Projects

Torrust Solution
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup Service Initialization Code

2 participants

@da2ce7 @josecelano