Move API healthcheck endpoint from /health_check to /api/health_check#538
Merged
josecelano merged 1 commit intotorrust:developfrom Dec 14, 2023
Merged
Conversation
From: `GET /health_check` To: `GET /api/health_check` To avoid collission with HTTP Tracker health check enpoint when the API and the HTTP Tracker are using the same domain+port. For example: - API: https://tracker.com:443/api/ - HTTP tracker: https://tracker.com:443/ Old health check endpoints: - API: https://tracker.com:443/health_check - HTTP tracker: https://tracker.com:443/health_check New API health check endpoint: - API: https://tracker.com:443/api/health_check - HTTP tracker: https://tracker.com:443/health_check
josecelano
force-pushed
the
issue-537-new-api-health-check-endpoint
branch
from
5ea4d1e to
985633e
Compare
Member
Author
|
ACK: 985633e |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #538 +/- ##
========================================
Coverage 84.20% 84.20%
========================================
Files 110 110
Lines 7285 7286 +1
========================================
+ Hits 6134 6135 +1
Misses 1151 1151 ☔ View full report in Codecov by Sentry. |
Contributor
|
The original plan was to have it under the v1 prefix, but this pull request doesn't include the version. Hmm? |
Member
Author
Hi @da2ce7 I changed my mind. In the end, I did what I mentioned at the end of the issue:
That means we are not versioning the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: torrust/torrust-compose#2
From:
GET /health_checkTo:
GET /api/health_checkTo avoid collission with HTTP Tracker health check enpoint when the API and the HTTP Tracker are using the same domain+port. For example:
Old health check endpoints:
New API health check endpoint: