Added tower-http compression as middleware on both HTTP routers#386
Merged
josecelano merged 2 commits intotorrust:developfrom Aug 26, 2023
alexohneander:develop
Merged
Added tower-http compression as middleware on both HTTP routers#386josecelano merged 2 commits intotorrust:developfrom alexohneander:develop
josecelano merged 2 commits intotorrust:developfrom
alexohneander:develop
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #386 +/- ##
===========================================
+ Coverage 83.95% 84.07% +0.12%
===========================================
Files 102 102
Lines 7267 7185 -82
===========================================
- Hits 6101 6041 -60
+ Misses 1166 1144 -22
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
da2ce7
approved these changes
Aug 26, 2023
Contributor
da2ce7
left a comment
da2ce7
left a comment
There was a problem hiding this comment.
Looks good to me. Surprisingly Simple!
Member
|
I've tested manually with the following: curl -I 'http://127.0.0.1:1212/api/v1/stats?token=MyAccessToken' -H 'Cache-Control: no-cache' -H 'Pragma: no-cache' -H 'Accept-Encoding: gzip'
curl -raw 'http://127.0.0.1:1212/api/v1/stats?token=MyAccessToken' -H 'Cache-Control: no-cache' -H 'Pragma: no-cache' -H 'Accept-Encoding: gzip' --output response.gz
gzip -d response.gz |
Member
|
ACK 22bb98a |
Contributor
Author
|
@josecelano It is also supported brotli curl -I 'http://127.0.0.1:1212/api/v1/stats?token=MyAccessToken' -H 'Cache-Control: no-cache' -H 'Pragma: no-cache' -H 'Accept-Encoding: br' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified:
I have added tower-http compression as middleware on both HTTP routers(API, Tracker HTTP).
All tests were run and were okay.