Merged
Conversation
Closed
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #367 +/- ##
===========================================
- Coverage 85.07% 85.01% -0.06%
===========================================
Files 88 89 +1
Lines 6564 6567 +3
===========================================
- Hits 5584 5583 -1
- Misses 980 984 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
All of then have the ENV_VAR prefix now. Like in the Index Backend. So we can identify constants that are related to env vars.
Now you can change the deafult location for the config file with an env var: ``` TORRUST_IDX_BACK_CONFIG_PATH="./storage/config.toml" cargo run ``` The default location is still `./config.toml`
Instead of halting the program, not the tracker continues the execution when no config.toml file is provided and the default one is created. It shows some messages: ``` Loading configuration from configuration file: `./config.toml` ... Missing configuration file. Creating a default configuration file: `./config.toml` ... Please review the config file: `./config.toml` and restart the tracker if needed. 2023-08-08T11:56:26.957162508+01:00 [torrust_tracker::bootstrap::logging][INFO] logging initialized. 2023-08-08T11:56:26.957931296+01:00 [torrust_tracker::bootstrap::jobs::tracker_apis][INFO] Starting Torrust APIs server on: http://127.0.0.1:1212 2023-08-08T11:56:26.958027355+01:00 [torrust_tracker::bootstrap::jobs::tracker_apis][INFO] Torrust APIs server started ```
Member
Author
|
There is a breaking change. I have removed the error when the default configuration is created: Loading configuration from config file ./config.toml
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: CreatedNewConfigHalt { location: Location { file: "packages/configuration/src/lib.rs", line: 520, col: 27 }, path: "./config.toml" }', src/bootstrap/app.rs:83:52
note: run with `RUST_BACKTRACE=1` environment variable to display a backtraceNow the tracker continues running with the default configuration file: Loading configuration from configuration file: `./config.toml` ...
Missing configuration file.
Creating a default configuration file: `./config.toml` ...
Please review the config file: `./config.toml` and restart the tracker if needed.
2023-08-08T12:16:24.548218890+01:00 [torrust_tracker::bootstrap::logging][INFO] logging initialized.
2023-08-08T12:16:24.548805484+01:00 [torrust_tracker::bootstrap::jobs::tracker_apis][INFO] Starting Torrust APIs server on: http://127.0.0.1:1212
2023-08-08T12:16:24.548882463+01:00 [torrust_tracker::bootstrap::jobs::tracker_apis][INFO] Torrust APIs server startedIf we implement the issue to make the database optional and we make the no-database option the default one, we could run the tracker with default configuration (only memory) with a single docker command. Alternatively, we could add a new env var |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor improvements to make using docker and the app configuration a smoother experience.