Merged
Conversation
da2ce7
force-pushed
the
20230804_docker_work
branch
2 times, most recently
from
8200bba to
9c881eb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #363 +/- ##
===========================================
+ Coverage 83.98% 84.19% +0.21%
===========================================
Files 102 102
Lines 7182 7208 +26
===========================================
+ Hits 6032 6069 +37
+ Misses 1150 1139 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment was marked as resolved.
This comment was marked as resolved.
da2ce7
force-pushed
the
20230804_docker_work
branch
2 times, most recently
from
79ed4ce to
52a0a82
Compare
da2ce7
force-pushed
the
20230804_docker_work
branch
10 times, most recently
from
39c3912 to
2e26d71
Compare
da2ce7
force-pushed
the
20230804_docker_work
branch
7 times, most recently
from
fc76313 to
a75a96a
Compare
Contributor
Author
|
@josecelano I am starting to become happy with our Dockerfile now. :) |
da2ce7
force-pushed
the
20230804_docker_work
branch
from
4bfbc2c to
971b26e
Compare
da2ce7
force-pushed
the
20230804_docker_work
branch
from
7d4178f to
dcbf9bf
Compare
da2ce7
force-pushed
the
20230804_docker_work
branch
4 times, most recently
from
96215e7 to
734f9ee
Compare
Contributor
Author
|
@josecelano Starting to Look More Complete. Need to continue reworking documentation. |
da2ce7
force-pushed
the
20230804_docker_work
branch
2 times, most recently
from
6efb901 to
0770467
Compare
da2ce7
force-pushed
the
20230804_docker_work
branch
4 times, most recently
from
7d78e8e to
88d7f49
Compare
Contributor
Author
|
@josecelano I believe that this Pull Request is Ready to Review. :) |
da2ce7
force-pushed
the
20230804_docker_work
branch
2 times, most recently
from
013dd67 to
9e9ebbf
Compare
da2ce7
had a problem deploying
to
dockerhub-torrust
GitHub Actions
Failure
da2ce7
force-pushed
the
20230804_docker_work
branch
from
9e9ebbf to
2942a15
Compare
josecelano
approved these changes
Aug 30, 2023
Member
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
It looks good to me. I've only made minor comments.
da2ce7
force-pushed
the
20230804_docker_work
branch
5 times, most recently
from
b7e52e0 to
0e90be0
Compare
da2ce7
force-pushed
the
20230804_docker_work
branch
from
0e90be0 to
5da5a25
Compare
Contributor
Author
|
ACK 5da5a25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #391
Ready for Review. :)
Big Update for Containers.
Todo:
Moved to a new issue: