Remove unused dependencies#300
Merged
josecelano merged 3 commits intotorrust:developfrom Apr 13, 2023
Merged
Conversation
Fields were reorganized and package test were not being executed on the CI.
Test for packages were not being executed. We need to add the `--workpspace` option: ``` cargo test --workspace ```
And move to `[dev-dependencies]` the ones that are only used for testing.
josecelano
requested review from
da2ce7 and
mickvandijke
and removed request for
mickvandijke
Member
Author
|
New Finished dev [optimized + debuginfo] target(s) in 6m 17s
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker_primitives-917508dd49d31277.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker_located_error-2c2e839e7e47b4ad.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker_configuration-b5b9ae74c043ec29.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker_test_helpers-9b67eb853ce6354b.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker-d38957fa91a60575.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker-130a2639e645edb8.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker-f134a734a9bb6022.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/torrust_tracker-b035c1b3dc467982.d"
info: Loading depinfo from "/home/josecelano/Documents/github/committer/me/torrust/torrust-tracker/target/debug/deps/integration-0b0e02f7c2719aac.d"
All deps seem to have been used. |
Codecov Report
@@ Coverage Diff @@
## develop #300 +/- ##
===========================================
- Coverage 89.26% 89.24% -0.02%
===========================================
Files 119 119
Lines 9911 9913 +2
===========================================
Hits 8847 8847
- Misses 1064 1066 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused dependencies detected by this command:
Some of them were false positives because they were used for testing. It was fixed by moving them from
[dependencies]to[dev-dependencies]section in theCargo.tomlfile.