Merged
Conversation
Adter intruducing the `KeyId` we no longer needed to have keys with no expiration date. A key without an expiration date is a `KeyId`. So all `ExpiraingKeys` have an expiration date.
There is no longer a clonflict with the `ExpiringKey` strcut that was also called `Key`.
c46d255 to
0ee5a51
Compare
Member
Author
…r key_id to `Key` and `key`. removing the `Id` and `id`, since the `KeyId` struct was renamed to `Key`.
0ee5a51 to
af038de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #171
The
ExpiringKey::valid_until(duration) does not need to be optional anymore since we introduced theKeyIdstruct.Besides, after renaming the
Keystruct toExpiringKey, there is no longer a conflict with theKeyId, so we can use the nameKeyfor theKeyIdagain.Before:
After:
After this refactoring, you can read the code like this:
"An
ExpiringKeyis aKeyvalid until a date expressed in a duration from the Unix epoch (timestamp)".