Skip to content

Isolate configuration and primitives in their own crates#174

Merged
mickvandijke merged 1 commit into156-fix-random-test-failure-due-to-port-collisionfrom
173-isolate-configuration-and-primitives-in-their-own-crates
Feb 4, 2023
Merged

Isolate configuration and primitives in their own crates#174
mickvandijke merged 1 commit into156-fix-random-test-failure-due-to-port-collisionfrom
173-isolate-configuration-and-primitives-in-their-own-crates

Conversation

@mickvandijke
Copy link
Copy Markdown
Member

@mickvandijke mickvandijke commented Feb 2, 2023

@josecelano
Copy link
Copy Markdown
Member

@WarmBeer I think we could use this folder structure:

.
├── packages
│   └── test-helpers
└── src

Instead of:

.
├── src
└── test-helpers

So that we can add more dependencies and make it more explicit that it's a dependency.

@da2ce7 da2ce7 added the Needs Rebase Base Branch has Incompatibilities label Feb 4, 2023
@mickvandijke mickvandijke changed the base branch from develop to 156-fix-random-test-failure-due-to-port-collision February 4, 2023 14:44
@mickvandijke mickvandijke marked this pull request as ready for review February 4, 2023 14:45
@mickvandijke mickvandijke merged commit 2c1c4f8 into 156-fix-random-test-failure-due-to-port-collision Feb 4, 2023
@mickvandijke mickvandijke deleted the 173-isolate-configuration-and-primitives-in-their-own-crates branch February 4, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Cleanup / Refactoring Tidying and Making Neat Needs Rebase Base Branch has Incompatibilities

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Isolate configuration and primitives in their own crates

3 participants