Skip to content

Ugrade workflow actions#166

Merged
josecelano merged 4 commits intotorrust:developfrom
josecelano:issue-165-upgrade-workflow-actions
Feb 2, 2023
Merged

Ugrade workflow actions#166
josecelano merged 4 commits intotorrust:developfrom
josecelano:issue-165-upgrade-workflow-actions

Conversation

@josecelano
Copy link
Copy Markdown
Member

No description provided.

@josecelano josecelano linked an issue Feb 1, 2023 that may be closed by this pull request
@josecelano josecelano force-pushed the issue-165-upgrade-workflow-actions branch from 10c7d57 to 3d1a12b Compare February 1, 2023 18:09
@josecelano
Copy link
Copy Markdown
Member Author

There is no newer version for actions-rs/toolchain

There is no newer version for actions-rs/cargo@v1.

It seems actions-rs is unmaintained actions-rs/cargo#222. See:

actions-rs/toolchain#216

There are some alternatives: actions-rs/toolchain#216

It seems dtolnay/rust-toolchain@stable is the replacement for actions-rs/toolchain

@josecelano
Copy link
Copy Markdown
Member Author

I don't see a replacement for actions-rs/cargo@v1. Maybe we should simply use cargo instead of an action.

@josecelano
Copy link
Copy Markdown
Member Author

Tokio-rs is using dtolnay/rust-toolchain@master. See: https://github.com/tokio-rs/tokio/blob/master/.github/workflows/ci.yml

…go commmands

Replaced with using the `cargo` command directly.
@josecelano josecelano marked this pull request as ready for review February 1, 2023 18:57
@josecelano
Copy link
Copy Markdown
Member Author

ACK 42e7e64

@da2ce7
Copy link
Copy Markdown
Contributor

da2ce7 commented Feb 1, 2023

Looks good to me. :)

@josecelano josecelano merged commit f860530 into torrust:develop Feb 2, 2023
@josecelano josecelano deleted the issue-165-upgrade-workflow-actions branch February 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Upgrade workflow actions to use Node 16

2 participants