Overhaul stats: Simplify torrent-repository package before adding events#1492
Merged
josecelano merged 20 commits intotorrust:developfrom May 2, 2025
Conversation
It will be removed from the `torrent-repository` package, keeping only data strcutures used in production.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1492 +/- ##
===========================================
+ Coverage 84.30% 84.74% +0.44%
===========================================
Files 255 259 +4
Lines 19878 20287 +409
Branches 19878 20287 +409
===========================================
+ Hits 16758 17193 +435
+ Misses 2806 2800 -6
+ Partials 314 294 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Repositories that are not used in production. THey have been moved to a new package `torrent-repository-benchmarking`.
Entry types that are not used in production. They have been moved to a new package `torrent-repository-benchmarking`.
…sync They have been moved to a new package `torrent-repository-benchmarking`.
This is part of a bigger refactor makeing the torrent-repositoru package impler. Only using types used in production and removing traits that only have one implementation.
I don't know why it was not happening before. The previous changes only: - Remove types aliases. - Remove generics. - Remove unused traits. However the concrete type for the repository should be the same after monomorphization.
…itory to TorrentRepository InMemoryTorrentRepository is now a wrapper over TorrentRepository. It's planned to make the InMemoryTorrentRepository responsible for triggering events.
Unneeded wrapper for TorrentRepository now that there is only one implementaion.
Member
Author
|
ACK 7215f6e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
torrent-repositorypackage before adding events. It would be overkill to maintain all the implementations.Subtasks
torrent-repository-benchmarking.torrent-repositorypackage.RepositoryAsync,EntryAsync,Entry,EntrySync, etc.Import theDISCARDED. See Overhaul stats: Emit events from thebittorrent_tracker_core::torrent::repository::in_memory::InMemoryTorrentRepositorytype from thetracker-repopackage.torrent-repositorypackage and collect metrics #1358 (comment).