Merged
Conversation
josecelano
force-pushed
the
issue-142-add-tests-for-the-api
branch
from
eac869b to
460489c
Compare
Member
Author
|
hi, @da2ce7 @WarmBeer this is ready to review. These are the tests I've added: test tracker_api::for_stats_resources::
should_allow_getting_tracker_statistics ... ok
should_not_allow_getting_tracker_statistics_for_unauthenticated_users ... ok
test tracker_api::for_torrent_resources::
should_allow_getting_a_torrent_info ... ok
should_allow_getting_torrents ... ok
should_allow_limiting_the_torrents_in_the_result ... ok
should_allow_the_torrents_result_pagination ... ok
should_not_allow_getting_a_torrent_info_for_unauthenticated_users ... ok
should_not_allow_getting_torrents_for_unauthenticated_users ... ok
test tracker_api::for_whitelisted_torrent_resources::
should_allow_reload_the_whitelist_from_the_database ... ok
should_allow_removing_a_torrent_from_the_whitelist ... ok
should_allow_whitelisting_a_torrent ... ok
should_allow_whitelisting_a_torrent_that_has_been_already_whitelisted ... ok
should_not_allow_removing_a_torrent_from_the_whitelist_for_unauthenticated_users ... ok
should_not_allow_whitelisting_a_torrent_for_unauthenticated_users ... ok
test tracker_api::for_key_resources::
should_allow_deleting_an_auth_key ... ok
should_allow_generating_a_new_auth_key ... ok
should_allow_reloading_keys ... ok
should_not_allow_deleting_an_auth_key_for_unauthenticated_users ... ok
should_not_allow_generating_a_new_auth_key_for_unauthenticated_users ... ok
should_not_allow_reloading_keys_for_unauthenticated_users ... ok |
josecelano
force-pushed
the
issue-142-add-tests-for-the-api
branch
from
460489c to
11259e8
Compare
Member
Author
|
ACK 11259e8 |
Member
Author
|
@WarmBeer why do you need to expose the reload whitelist ( |
Member
These commands are for reloading the states from the database. This is useful when an administrator wants to update the tracker whitelist using the database for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some tests to the API before changing the web framework to Axum.