Refactor: improve REST API client#1335
Merged
josecelano merged 1 commit intotorrust:developfrom Feb 28, 2025
Merged
Conversation
- Add a timeout to the requests. - Return an error in the construction if it can't build the HTTP client. - Extract constants.
Member
Author
|
ACK 89b0bfd |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1335 +/- ##
===========================================
- Coverage 81.53% 81.52% -0.02%
===========================================
Files 230 230
Lines 16358 16368 +10
Branches 16358 16368 +10
===========================================
+ Hits 13338 13344 +6
Misses 2792 2792
- Partials 228 232 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: improve REST API client: