docs: remove code-review comment#1305
Merged
josecelano merged 1 commit intotorrust:developfrom Feb 20, 2025
Merged
Conversation
We decided not to change it. - The returned value is simpler. - We force the initial peer to change so there is no confusion about what was the final announced peer.
josecelano
added
Documentation
Member
Author
|
ACK bc95fc4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1305 +/- ##
========================================
Coverage 81.13% 81.13%
========================================
Files 215 215
Lines 15279 15275 -4
Branches 15279 15275 -4
========================================
- Hits 12397 12394 -3
Misses 2671 2671
+ Partials 211 210 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided not to change it.