Skip to content

Overhaul core Tracker: add tests for whitelist mod#1237

Merged
josecelano merged 6 commits intotorrust:developfrom
josecelano:1235-overhaul-core-tracker-add-tests-for-whitelist-mod
Feb 5, 2025
Merged

Overhaul core Tracker: add tests for whitelist mod#1237
josecelano merged 6 commits intotorrust:developfrom
josecelano:1235-overhaul-core-tracker-add-tests-for-whitelist-mod

Conversation

@josecelano
Copy link
Copy Markdown
Member

@josecelano josecelano commented Feb 4, 2025 •
edited
Loading

Overhaul core Tracker: add tests for whitelist mod

Coverage before:

Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
packages/tracker-core/src/whitelist/authorization.rs                             18                 0   100.00%           8                 0   100.00%          46                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/manager.rs                                   49                 7    85.71%          21                 3    85.71%         113                 7    93.81%           0                 0         -
packages/tracker-core/src/whitelist/mod.rs                                       13                 0   100.00%           4                 0   100.00%          33                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/repository/in_memory.rs                      28                 0   100.00%          16                 0   100.00%          85                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/repository/persisted.rs                      22                 6    72.73%           4                 0   100.00%          24                 2    91.67%           0                 0         -
packages/tracker-core/src/whitelist/setup.rs                                      1                 0   100.00%           1                 0   100.00%           7                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/whitelist_tests.rs                            3                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -

Coverage after:

Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
packages/tracker-core/src/whitelist/authorization.rs                             35                 1    97.14%          16                 0   100.00%         100                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/manager.rs                                   39                 3    92.31%          15                 0   100.00%         109                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/mod.rs                                       13                 0   100.00%           4                 0   100.00%          33                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/repository/in_memory.rs                      28                 0   100.00%          16                 0   100.00%          85                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/repository/persisted.rs                      33                 4    87.88%          10                 0   100.00%          79                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/setup.rs                                      1                 0   100.00%           1                 0   100.00%           7                 0   100.00%           0                 0         -
packages/tracker-core/src/whitelist/whitelist_tests.rs                            3                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -

@josecelano josecelano self-assigned this Feb 4, 2025
@josecelano josecelano requested a review from da2ce7 February 4, 2025 16:46
@josecelano josecelano added Quality & Assurance Relates to QA, Testing, and CI - Developer - Torrust Improvement Experience Testing Checking Torrust labels Feb 4, 2025
@josecelano josecelano linked an issue Feb 4, 2025 that may be closed by this pull request
Overhaul core Tracker: add tests for whitelist mod #1235
Closed
@josecelano
refactor: [torrust#1235] remove pun method only used for testing
f32f0bf 
Now that we inject dependencies we can write assert using the dependencies instead of exposing public methods.
@josecelano josecelano marked this pull request as ready for review February 5, 2025 10:07
@josecelano
Copy link
Copy Markdown
Member Author

josecelano commented Feb 5, 2025

ACK e994aa2

@josecelano josecelano merged commit 109aef6 into torrust:develop Feb 5, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels

- Developer - Torrust Improvement Experience Quality & Assurance Relates to QA, Testing, and CI Testing Checking Torrust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: add tests for whitelist mod

1 participant

@josecelano