Overhaul core Tracker: add tests for `authentication` mod by josecelano · Pull Request #1232 · torrust/torrust-tracker

josecelano · 2025-02-03T10:35:15Z

Overhaul core Tracker: add tests for authentication mod.

Coverage before:

Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
packages/tracker-core/src/authentication/handler.rs                              85                17    80.00%          28                 1    96.43%         203                35    82.76%           0                 0         -
packages/tracker-core/src/authentication/key/mod.rs                              55                 7    87.27%          18                 3    83.33%         124                12    90.32%           0                 0         -
packages/tracker-core/src/authentication/key/repository/in_memory.rs             23                 5    78.26%          10                 2    80.00%          25                 5    80.00%           0                 0         -
packages/tracker-core/src/authentication/key/repository/persisted.rs             15                 3    80.00%           4                 0   100.00%          17                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/mod.rs                                  67                 0   100.00%          19                 0   100.00%         201                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/service.rs                              22                 2    90.91%

Coverage after:

Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
packages/tracker-core/src/authentication/handler.rs                             158                 9    94.30%          52                 0   100.00%         583                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/mod.rs                              35                 3    91.43%          11                 0   100.00%          96                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/peer_key.rs                         39                 0   100.00%          17                 0   100.00%         102                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/repository/in_memory.rs             51                 0   100.00%          20                 0   100.00%         169                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/key/repository/persisted.rs             24                 2    91.67%           8                 0   100.00%          77                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/mod.rs                                  67                 0   100.00%          19                 0   100.00%         219                 0   100.00%           0                 0         -
packages/tracker-core/src/authentication/service.rs                              52                 0   100.00%          20                 0   100.00%         268                 0   100.00%           0                 0         -

We don't need the whole tracker config.

…::tests

tests that require the `Database` trait.

josecelano · 2025-02-04T13:56:45Z

ACK 3d89c7f

josecelano self-assigned this Feb 3, 2025

josecelano added Quality & Assurance Relates to QA, Testing, and CI - Developer - Torrust Improvement Experience Testing Checking Torrust labels Feb 3, 2025

josecelano had a problem deploying to coverage February 3, 2025 10:35 — with GitHub Actions Failure

josecelano linked an issue Feb 3, 2025 that may be closed by this pull request

Overhaul core Tracker: add tests for authentication mod #1231

Closed

josecelano requested a review from da2ce7 February 3, 2025 10:35

test: [torrust#1231] add tests for InMemoryKeyRepository

8efda62

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from dc4e44d to 8efda62 Compare February 3, 2025 10:36

josecelano had a problem deploying to coverage February 3, 2025 10:37 — with GitHub Actions Failure

chore: add todo

04ee425

josecelano had a problem deploying to coverage February 3, 2025 11:29 — with GitHub Actions Failure

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from 8397033 to f9bcb79 Compare February 3, 2025 11:30

test: add tests for DatabaseKeyRepository

7c8d294

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from f9bcb79 to 7c8d294 Compare February 3, 2025 11:30

josecelano had a problem deploying to coverage February 3, 2025 11:32 — with GitHub Actions Failure

josecelano had a problem deploying to coverage February 3, 2025 11:52 — with GitHub Actions Failure

josecelano added 3 commits February 3, 2025 12:12

refactor: inject only core config in tracker core DB setup

f485a52

refactor: [torrust#1231] simplify tests for DatabaseKeyRepository

e519e7f

We don't need the whole tracker config.

refactor: [torrust#1231] improve DatabaseKeyRepository tests

8709540

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from a2bbdec to 8709540 Compare February 3, 2025 12:18

josecelano had a problem deploying to coverage February 3, 2025 12:18 — with GitHub Actions Failure

refactor: [torrust#1231] exctract mod

0336ca7

josecelano had a problem deploying to coverage February 3, 2025 12:32 — with GitHub Actions Failure

josecelano added 2 commits February 3, 2025 12:59

test: [torrust#1231] add more tests to peer_key mod

5d91a32

refactor: [torrust#1231] peer_key mod tests

d0c7313

josecelano had a problem deploying to coverage February 3, 2025 13:24 — with GitHub Actions Failure

refactor: [torrust#1231] bittorrent_tracker_core::authentication::key…

0d7e30e

…::tests

josecelano had a problem deploying to coverage February 3, 2025 16:02 — with GitHub Actions Failure

refactor: rename methods

5db73be

test: [torrust#1231] add tests for KeysHandler

e3ba1e1

josecelano had a problem deploying to coverage February 3, 2025 17:50 — with GitHub Actions Failure

josecelano had a problem deploying to coverage February 4, 2025 08:57 — with GitHub Actions Failure

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from 218dc14 to abd7bca Compare February 4, 2025 10:31

josecelano had a problem deploying to coverage February 4, 2025 10:31 — with GitHub Actions Failure

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from abd7bca to b40de68 Compare February 4, 2025 11:14

josecelano had a problem deploying to coverage February 4, 2025 11:15 — with GitHub Actions Failure

refactor: [torrust#1231] tests to use database mock in KeysHandler

bd4cef6

tests that require the `Database` trait.

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from b40de68 to bd4cef6 Compare February 4, 2025 11:17

josecelano had a problem deploying to coverage February 4, 2025 11:18 — with GitHub Actions Failure

josecelano added 2 commits February 4, 2025 12:17

test: [torrust#1231] add more tests for KeysHandler

c3117cf

refactor: [torrust#1231] remove dead code

63e773a

josecelano had a problem deploying to coverage February 4, 2025 12:25 — with GitHub Actions Failure

josecelano had a problem deploying to coverage February 4, 2025 12:55 — with GitHub Actions Failure

test: [torrust#1231] add tests for AuthenticationService

7d8b394

josecelano force-pushed the 1231-overhaul-core-tracker-add-tests-for-authentication-mod branch from 1e6b8bf to 7d8b394 Compare February 4, 2025 13:07

josecelano had a problem deploying to coverage February 4, 2025 13:07 — with GitHub Actions Failure

test: [torrust#1231] add more tests for authentication::service mod

3e02b48

josecelano had a problem deploying to coverage February 4, 2025 13:18 — with GitHub Actions Failure

josecelano marked this pull request as ready for review February 4, 2025 13:18

fix: [torrust#1231] lint errors

3d89c7f

josecelano had a problem deploying to coverage February 4, 2025 13:20 — with GitHub Actions Failure

josecelano merged commit 4a9c083 into torrust:develop Feb 4, 2025
20 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul core Tracker: add tests for `authentication` mod#1232

Overhaul core Tracker: add tests for `authentication` mod#1232
josecelano merged 18 commits intotorrust:developfrom
josecelano:1231-overhaul-core-tracker-add-tests-for-authentication-mod

josecelano commented Feb 3, 2025 •

edited

Loading

Uh oh!

josecelano commented Feb 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

josecelano commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josecelano commented Feb 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

josecelano commented Feb 3, 2025 •

edited

Loading