Skip to content

Overhaul core Tracker: create dependency containers for UDP tracker, HTTP tracker and Tracker API#1218

Merged
josecelano merged 4 commits intotorrust:developfrom
josecelano:1217-overhaul-core-tracker-create-dependency-containers-for-udp-tracker-http-tracker-and-tracker-api
Jan 29, 2025
Merged

Overhaul core Tracker: create dependency containers for UDP tracker, HTTP tracker and Tracker API#1218
josecelano merged 4 commits intotorrust:developfrom
josecelano:1217-overhaul-core-tracker-create-dependency-containers-for-udp-tracker-http-tracker-and-tracker-api

Conversation

@josecelano
Copy link
Copy Markdown
Member

@josecelano josecelano commented Jan 28, 2025

Overhaul core Tracker: create dependency containers for UDP tracker, HTTP tracker and Tracker API.

Subtasks

  • Extract UdpTrackerContainer
  • Extract HttpTrackerContainer
  • Extract HttpApiContainer

@josecelano josecelano self-assigned this Jan 28, 2025
@josecelano josecelano requested a review from da2ce7 January 28, 2025 18:50
@josecelano josecelano added - Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat labels Jan 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 93.65079% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.74%. Comparing base (b8e0803) to head (b38e4af).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...-client/src/console/clients/checker/checks/http.rs 0.00% 2 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️
...r-client/src/console/clients/checker/checks/udp.rs 0.00% 1 Missing ⚠️
...racker-client/src/http/client/requests/announce.rs 0.00% 1 Missing ⚠️
.../tracker-client/src/http/client/requests/scrape.rs 0.00% 1 Missing ⚠️
src/console/profiling.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1218      +/-   ##
===========================================
- Coverage    77.84%   77.74%   -0.11%     
===========================================
  Files          195      196       +1     
  Lines        12856    12773      -83     
  Branches     12856    12773      -83     
===========================================
- Hits         10008     9930      -78     
+ Misses        2680     2675       -5     
  Partials       168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1217-overhaul-core-tracker-create-dependency-containers-for-udp-tracker-http-tracker-and-tracker-api branch from 4a43e0f to d564391 Compare January 29, 2025 08:29
@josecelano josecelano force-pushed the 1217-overhaul-core-tracker-create-dependency-containers-for-udp-tracker-http-tracker-and-tracker-api branch from d564391 to 5342a5d Compare January 29, 2025 09:20
@josecelano josecelano force-pushed the 1217-overhaul-core-tracker-create-dependency-containers-for-udp-tracker-http-tracker-and-tracker-api branch from 2f86d54 to 66b2b56 Compare January 29, 2025 11:28
to avoid IDE warnings for infohashe values in tests.
@josecelano
Copy link
Copy Markdown
Member Author

ACK b38e4af

@josecelano josecelano marked this pull request as ready for review January 29, 2025 11:35
@josecelano josecelano merged commit 46e9d25 into torrust:develop Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: create dependency containers for UDP tracker, HTTP tracker and Tracker API

1 participant