Skip to content

Overhaul core Tracker: extract torrents context (part 2)#1204

Merged
josecelano merged 4 commits intotorrust:developfrom
josecelano:1203-overhaul-core-tracker-extract-torrents-context-part-2
Jan 24, 2025
Merged

Overhaul core Tracker: extract torrents context (part 2)#1204
josecelano merged 4 commits intotorrust:developfrom
josecelano:1203-overhaul-core-tracker-extract-torrents-context-part-2

Conversation

@josecelano
Copy link
Copy Markdown
Member

@josecelano josecelano commented Jan 24, 2025 •
edited
Loading

This is part 2 of the refactor initiated here.

The core Tracker after this refactor:

pub struct Tracker {
    /// The tracker configuration.
    config: Core,

    /// The service to check is a torrent is whitelisted.
    whitelist_authorization: Arc<whitelist::authorization::Authorization>,

    /// The in-memory torrents repository.
    in_memory_torrent_repository: Arc<InMemoryTorrentRepository>,

    /// The persistent torrents repository.
    db_torrent_repository: Arc<DatabasePersistentTorrentRepository>,
}

@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 24, 2025
@josecelano josecelano requested a review from da2ce7 January 24, 2025 08:46
@josecelano josecelano self-assigned this Jan 24, 2025
@josecelano josecelano linked an issue Jan 24, 2025 that may be closed by this pull request
Overhaul core Tracker: extract torrents context (part 2) #1203
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (a4277a7) to head (046578d).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1204      +/-   ##
===========================================
+ Coverage    78.03%   78.39%   +0.36%     
===========================================
  Files          191      191              
  Lines        12999    13097      +98     
  Branches     12999    13097      +98     
===========================================
+ Hits         10144    10268     +124     
+ Misses        2687     2668      -19     
+ Partials       168      161       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1203-overhaul-core-tracker-extract-torrents-context-part-2 branch from 6ceb3fb to 046578d Compare January 24, 2025 10:50
@josecelano josecelano marked this pull request as ready for review January 24, 2025 10:50
@josecelano
Copy link
Copy Markdown
Member Author

josecelano commented Jan 24, 2025

ACK 046578d

@josecelano josecelano merged commit 731fd01 into torrust:develop Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels

- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: extract torrents context (part 2)

1 participant

@josecelano