Overhaul core Tracker: refactor authentication module#1196
Merged
josecelano merged 18 commits intotorrust:developfrom Jan 22, 2025
Merged
Conversation
We will add more submodules.
josecelano
added
Code Cleanup / Refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1196 +/- ##
===========================================
+ Coverage 77.65% 77.86% +0.20%
===========================================
Files 184 188 +4
Lines 12651 12811 +160
Branches 12651 12811 +160
===========================================
+ Hits 9824 9975 +151
- Misses 2662 2673 +11
+ Partials 165 163 -2 ☔ View full report in Codecov by Sentry. |
It was used to group methods by services in the old core tracker.
These tests do not require the authentication service.
Facade service will be removed.
…cade The Facade will be replaced by its dependencies.
Instead of via the authentication::Facade. The Facade will be removed.
…tion Facade It's now used directly.
josecelano
force-pushed
the
1195-overhaul-core-tracker-refactor-authentication-module
branch
from
3ee78bb to
dff6bca
Compare
Member
Author
|
ACK dff6bca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhaul core Tracker: refactor authentication module.