Overhaul core Tracker: extract authentication#1192
Merged
josecelano merged 10 commits intotorrust:developfrom Jan 21, 2025
Merged
Overhaul core Tracker: extract authentication#1192josecelano merged 10 commits intotorrust:developfrom
josecelano merged 10 commits intotorrust:developfrom
Conversation
We will add more mods inside. This is part of a bigger refactor.
josecelano
added
Code Cleanup / Refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1192 +/- ##
===========================================
+ Coverage 77.46% 77.65% +0.19%
===========================================
Files 183 184 +1
Lines 12539 12651 +112
Branches 12539 12651 +112
===========================================
+ Hits 9713 9824 +111
Misses 2662 2662
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
The `auth` name is ambiguous, it could mean authorization.
It's a temporary type to extract responsability from the tracker.
josecelano
force-pushed
the
1191-overhaul-core-tracker-extract-authentication
branch
from
5b12115 to
562de4d
Compare
josecelano
force-pushed
the
1191-overhaul-core-tracker-extract-authentication
branch
from
562de4d to
5aae933
Compare
…d service in the core tracker
josecelano
force-pushed
the
1191-overhaul-core-tracker-extract-authentication
branch
from
5aae933 to
39c2a8f
Compare
There were copied to the authentication module.
Member
Author
|
ACK 6584fe4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhaul core Tracker: extract authentication.