Refactor: rename peer.updated field in torrent detail endpoint#119
Refactor: rename peer.updated field in torrent detail endpoint#119josecelano merged 8 commits intodevelopfrom
Conversation
Marked as deprecated. It will be a breaking change in version v3.0.0.
105dfb2 to
bc3d246
Compare
|
looks good. however this pull-request will conflict much with #115 , we need to choose what one we merge first. |
hi @da2ce7 I think It's probably better if I rework my changes on top of your PR because:
This PR is ready for review, but you can wait until I fix conflicts with your changes. The change was very easy, but I've added e2e tests for many endpoints. I think these tests are good because they cover many things, not only the API layer. Besides, It will be easy to add more API tests. |
Okay, we merge this first. Then I will try and rebase #115 on top of this. I like having more checks. |
|
ACK e1b84f6 |
TODO:
TorrentResourcelikeAuthKeyResource./api/torrents?offset=:u32&limit=:u32to useTorrentResource.updated_milliseconds_ago) to the JSON response keeping the old one for backwards compatibility.