Refactor: extract WhitelistManager#1183
Merged
josecelano merged 11 commits intotorrust:developfrom Jan 15, 2025
Merged
Conversation
josecelano
added
Code Cleanup / Refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1183 +/- ##
===========================================
+ Coverage 76.22% 76.60% +0.38%
===========================================
Files 178 181 +3
Lines 11898 12002 +104
Branches 11898 12002 +104
===========================================
+ Hits 9069 9194 +125
+ Misses 2658 2646 -12
+ Partials 171 162 -9 ☔ View full report in Codecov by Sentry. |
josecelano
force-pushed
the
1182-overhaul-core-tracker-extract-whitelist
branch
from
1aa312b to
cc2bc7b
Compare
Inject the database (persistence) and whitelist manager into the Tracker via the contructor to be able to use the whitelist manager directly in Axum handlers.
directly, instead of using it via the Tracker.
…cker factory Refactor in progress. The final goal is to inject the whitelist manager directly wherever is needed (for example, test evns) to avoid injecting the whole tracker. Adn to finally remove the whitelist manager from the Tracker (A higer level refator in progress: remove responsabilities fromcore Tracker).
Member
Author
|
ACK 57455ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: extract
WhitelistManager