#1040: continue when finding errors#1064
Merged
josecelano merged 1 commit intotorrust:developfrom Oct 17, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1064 +/- ##
========================================
Coverage 77.32% 77.32%
========================================
Files 178 178
Lines 10269 10269
========================================
Hits 7940 7940
Misses 2329 2329 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Retroactively signed the commit - I didn't have GPG keys set up on my laptop for some reason 😅 |
josecelano
approved these changes
Oct 17, 2024
Member
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
Hi @abstralexis thank you very much for your contribution.
I've tried with two trackers, one working and the other failing:
TORRUST_CHECKER_CONFIG='{
"udp_trackers": ["127.0.0.1:6969", "udp://tracker.torrust-demo.com:6969"],
"http_trackers": [],
"health_checks": []
}' cargo run --bin tracker_checker
Member
|
ACK a34f66e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the behaviour of UDP checks exiting on first fail (#1040). Was
breaking instead ofcontinueing when iterating over each test.