Tracker checker supports more service address formats#1041
Merged
josecelano merged 2 commits intotorrust:developfrom Sep 12, 2024
Conversation
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
…mats
All the following URL for UDP trackers are allow now:
```console
TORRUST_CHECKER_CONFIG='{
"udp_trackers": [
"127.0.0.1:6969",
"127.0.0.1:6969/",
"127.0.0.1:6969/announce",
"localhost:6969",
"localhost:6969/",
"localhost:6969/announce",
"udp://127.0.0.1:6969",
"udp://127.0.0.1:6969/",
"udp://127.0.0.1:6969/announce",
"udp://localhost:6969",
"udp://localhost:6969/",
"udp://localhost:6969/announce"
],
"http_trackers": [],
"health_checks": []
}' cargo run --bin tracker_checker
```
NOTICE: the client will resolve the domain to a socket address if
needed.
josecelano
force-pushed
the
675-tracker-checker-support-different-types-of-tracker-addresses
branch
from
a66d9ec to
520026d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1041 +/- ##
===========================================
+ Coverage 77.19% 77.32% +0.13%
===========================================
Files 178 178
Lines 10180 10269 +89
===========================================
+ Hits 7858 7941 +83
- Misses 2322 2328 +6 ☔ View full report in Codecov by Sentry. |
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
…ice address formats Now it supports a path prefix. It will be remove by the client to build the "scrape" URLs. This type of URL is very common in tracker lists like in https://newtrackon.com/. ```console TORRUST_CHECKER_CONFIG='{ "udp_trackers": [], "http_trackers": [ "http://127.0.0.1:7070", "http://127.0.0.1:7070/", "http://127.0.0.1:7070/announce" ], "health_checks": [] }' cargo run --bin tracker_checker ```
josecelano
force-pushed
the
675-tracker-checker-support-different-types-of-tracker-addresses
branch
from
85b1726 to
faee02f
Compare
Member
Author
|
ACK faee02f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDP Trackers
All the following URLs for UDP trackers are now allowed:
NOTICE: the client will resolve the domain to an IP address if it's needed.
HTTP Trackers
Now, it supports a path suffix (
/or/announce). It will be removed by the client to buildthe "scrape" URLs.
This type of URL is widespread in tracker lists like https://newtrackon.com/.