Allow UDP clients to limit peers in response#1035
Merged
josecelano merged 2 commits intotorrust:developfrom Sep 11, 2024
Merged
Conversation
josecelano
added
Enhancement / Feature Request
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1035 +/- ##
===========================================
+ Coverage 77.05% 77.24% +0.18%
===========================================
Files 178 178
Lines 10068 10181 +113
===========================================
+ Hits 7758 7864 +106
- Misses 2310 2317 +7 ☔ View full report in Codecov by Sentry. |
The UDP tracker announce response always include all peers available up to a maxium of 74 peers, ignoring the `num_want` param in the request described in: https://www.bittorrent.org/beps/bep_0015.html This change applies that limit only when is lower than then TORRENT_PEERS_LIMIT (74).
josecelano
force-pushed
the
569-the-tracker-is-ignoring-the-num_want-param-in-the-announce-request
branch
from
21f6b2e to
481d413
Compare
It allows HTTP clients to limit peers in the announce response with the `numwant` GET param.
Member
Author
|
ACK 084879e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UDP tracker announce response always include all peers available up to a maxium of 74 peers, ignoring the
num_wantparam in the request described in:https://www.bittorrent.org/beps/bep_0015.html
This change applies that limit only when is lower than then TORRENT_PEERS_LIMIT (74).
It also adds the
numwantGET param to the announce request for the HTTP tracker for the same purpose.num_want, positional param in the UDP packet).numwantGET param).