Fix bug: the tracker should always remove inactive peers#1003
Merged
josecelano merged 2 commits intotorrust:developfrom Aug 8, 2024
Merged
Conversation
even when `remove_peerless_torrents` is disabled. We should remove peer that haven't announce otherwise we are returning inactive peers to the clients. That does not affect keeping the torrents even if they don't have any peer.
A "good" torrent means it should be retained in the repository according to the tracker policy. It should not be removed (even if it does not have any peers).
Member
Author
|
ACK 3fbab31 |
josecelano
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1003 +/- ##
========================================
Coverage 77.10% 77.10%
========================================
Files 185 185
Lines 10063 10063
========================================
Hits 7759 7759
Misses 2304 2304 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug: the tracker should always remove inactive peers even when the config option
core.tracker_policy.remove_peerless_torrentsis disabled.Refactor: rename the
is_goodfunction tomeets_retaining_policyto be more specific.