Merged
Conversation
Contributor
|
@josecelano before enabling clippy in the CI, we should fix all the errors... |
josecelano
force-pushed
the
nightly-toolchain-for-formatting
branch
4 times, most recently
from
28a7ff2 to
37ac14e
Compare
@da2ce7 started using the nightly build for rust formatting here: #99 And the job 'format' in the workflow did not work, showing these warnings: ``` Warning: can't set `imports_granularity = Module`, unstable features are only available in nightly channel. Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel. Warning: can't set `imports_granularity = Module`, unstable features are only available in nightly channel. Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel. ``` So we needed the nightly channel anyway.
josecelano
force-pushed
the
nightly-toolchain-for-formatting
branch
from
37ac14e to
f2eaf95
Compare
Member
Author
Yes. I was only testing that the command works if we add it in the future. |
Member
Author
|
ACK f2eaf95 |
Contributor
|
@josecelano why change to use the cargo action? |
Member
Author
@da2ce7 I think the action will create an "annotation" (GitHub UI) when something fails. The cargo command would only show the error in the logs. That was the only reason. Anyway, you can easily enable cross-compilation. Although we do not need it in this case. @WarmBeer was working on this cross-compilation issue. Maybe we could add a workflow to compile for different targets in the future. |
da2ce7
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@da2ce7 started using the nightly build for rust formatting in this PR-99
And the job 'format' in the workflow did not work, showing these warnings:
So we needed the nightly channel anyway. I've changed the workflow to use it.