Merge #300: Remove unused dependencies

josecelano · josecelano · commit 3dffd83b2357 · 2023-04-13T11:10:22.000+01:00
823537e fix: [#234] remove unused dependencies (Jose Celano) a933a69 ci: run tests for workspace packages (Jose Celano) feaa173 fix: test for configuration (Jose Celano) Pull request description: Remove unused dependencies detected by this command: ``` cargo +nightly udeps --all-targets ``` Some of them were false positives because they were used for testing. It was fixed by moving them from `[dependencies]` to `[dev-dependencies]` section in the `Cargo.toml` file. Top commit has no ACKs. Tree-SHA512: 24a5eafa97f5976f6990361ddda835a138807d9032d04958113f5d916b6b52bb3fa5bec47b4634e5a0f72f9438ca23a72060f4d0fbc7eea8c5e2e5ab22860ddd
diff --git a/.github/workflows/test_build_release.yml b/.github/workflows/test_build_release.yml
@@ -36,9 +36,11 @@ jobs:
         run: cargo clippy --all-targets -- -D clippy::pedantic
       - name: Test Documentation
         run: cargo test --doc
+      - name: Run Tests
+        run: cargo test --workspace        
       - uses: taiki-e/install-action@cargo-llvm-cov
       - uses: taiki-e/install-action@nextest
-      - name: Run Tests
+      - name: Show coverage
         run: cargo llvm-cov nextest
 
   build:
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -18,13 +18,11 @@ serde = { version = "1.0", features = ["derive"] }
 serde_bencode = "^0.2"
 serde_json = "1.0"
 serde_with = "2.0"
-hex = "0.4"
 percent-encoding = "2.2"
 binascii = "0.1"
 lazy_static = "1.4"
 openssl = { version = "0.10", features = ["vendored"] }
 config = "0.13"
-toml = "0.7"
 log = { version = "0.4", features = ["release_max_level_info"] }
 fern = "0.6"
 chrono = "0.4"
diff --git a/packages/configuration/Cargo.toml b/packages/configuration/Cargo.toml
@@ -15,4 +15,6 @@ log = { version = "0.4", features = ["release_max_level_info"] }
 thiserror = "1.0"
 torrust-tracker-primitives = { version = "3.0.0-alpha.1", path = "../primitives" }
 torrust-tracker-located-error = { version = "3.0.0-alpha.1", path = "../located-error" }
+
+[dev-dependencies]
 uuid = { version = "1", features = ["v4"] }
diff --git a/packages/configuration/src/lib.rs b/packages/configuration/src/lib.rs
@@ -557,10 +557,14 @@ impl Configuration {
     /// permission to read it. Will also return `Err` if the configuration is
     /// not valid or cannot be encoded to TOML.
     pub fn save_to_file(&self, path: &str) -> Result<(), Error> {
-        let toml_string = toml::to_string(self).expect("Could not encode TOML value");
-        fs::write(path, toml_string).expect("Could not write to file!");
+        fs::write(path, self.to_toml()).expect("Could not write to file!");
         Ok(())
     }
+
+    /// Encodes the configuration to TOML.
+    fn to_toml(&self) -> String {
+        toml::to_string(self).expect("Could not encode TOML value")
+    }
 }
 
 #[cfg(test)]
@@ -575,11 +579,11 @@ mod tests {
                                 db_path = "./storage/database/data.db"
                                 announce_interval = 120
                                 min_announce_interval = 120
-                                max_peer_timeout = 900
                                 on_reverse_proxy = false
                                 external_ip = "0.0.0.0"
                                 tracker_usage_statistics = true
                                 persistent_torrent_completed_stat = false
+                                max_peer_timeout = 900
                                 inactive_peer_cleanup_interval = 600
                                 remove_peerless_torrents = true
 
diff --git a/packages/located-error/Cargo.toml b/packages/located-error/Cargo.toml
@@ -8,4 +8,7 @@ edition.workspace = true
 
 [dependencies]
 log = { version = "0.4", features = ["release_max_level_info"] }
+
+[dev-dependencies]
 thiserror = "1.0"
+
diff --git a/packages/test-helpers/Cargo.toml b/packages/test-helpers/Cargo.toml
@@ -7,7 +7,6 @@ authors.workspace = true
 edition.workspace = true
 
 [dependencies]
-tokio = { version = "1", features = ["rt-multi-thread", "net", "sync", "macros", "signal"] }
 lazy_static = "1.4"
 rand = "0.8.5"
 torrust-tracker-configuration = { version = "3.0.0-alpha.1", path = "../configuration"}
