Pull Request | Milestone 1.10#58
Pull Request | Milestone 1.10#58BelieveInBunny wants to merge 15 commits intotorrust:v1.1.0from Piracy-Wiki:main
Conversation
added Invitation Link
Unmodified Copy of the Nautilus Librarian Licensing Docs
mickvandijke
left a comment
There was a problem hiding this comment.
Hey @BelieveInBunny , thank you for the PR. This has been a much requested feature, so the community will definitely appreciate your work!
But before we can merge this, could you please consider the following changes:
- Add
backend/DATABASE,backend/DATABASE-shmandbackend/DATABASE-walto.gitignore. - I'm not sure what the purpose of
backend/gobangis. Could you explain to me why we need it or else remove it. - Add
backend/src/config.tomlto.gitignore. The config file should be automatically generated when running the backend. - Delete
backend/test.sqlandbackend/todo. I believe these files are no longer necessary. - Set
server.portinfrontend/vite.config.jsback to 8080.
Thank you.
yes, working on it now |
|
Hello @WarmBeer
Regarding this, gobang is database management tool to help edit database. If you think it might be a good idea to keep it. awesome. |
It is not good practice to include binaries within the repository. It is better if we remove gobang from this pull request and instead update the Backend's ReadMe File with a link to: https://github.com/TaKO8Ki/gobang |
I agree on it, I will note this for future coding |
|
Updated |
|
I hope everything is good now to merge the request. |
|
Lets first split this into two pull requests:
This will be easier to review. :) You can start with the more simple "Enable/Disable New User Registration". |
|
Thank you, I will close this pull request and create 2 seperate then |
Uh oh!
There was an error while loading. Please reload this page.