Add prefix v1 to tracker API#95
Merged
josecelano merged 1 commit intotorrust:developfrom Mar 14, 2023
josecelano:issue-94-add-prefix-v1-to-tracker-api
Merged
Add prefix v1 to tracker API#95josecelano merged 1 commit intotorrust:developfrom josecelano:issue-94-add-prefix-v1-to-tracker-api
v1 to tracker API#95josecelano merged 1 commit intotorrust:developfrom
josecelano:issue-94-add-prefix-v1-to-tracker-api
Conversation
The tracker API uses now a prefix with the version. It has changed from: http://0.0.0.0:1212/api/stats?token=MyAccessToken to http://0.0.0.0:1212/api/v1/stats?token=MyAccessToken
Member
Author
|
Hi @da2ce7 @WarmBeer, this is ready to review. I've just added the API prefix. As I mentioned here, we have duplicate code for the API client, but it requires some changes in the tracker if we want to extract that part to reuse it here. On the other hand, I would refactor the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracker API uses now a prefix with the version. It has changed from:
http://0.0.0.0:1212/api/stats?token=MyAccessToken
to:
http://0.0.0.0:1212/api/v1/stats?token=MyAccessToken