Merged
Conversation
Member
|
hi @da2ce7, I think we are again in the same situation :-). PR #77 is done, and It probably has a lot of conflicts with this one. In this case, it contains a lot of tests, but only for the new feature (upgrader). But I think PR #77 contains a lot of additions and few modifications. I suppose we can merge any of them first. Let me know which one you prefer merging first. Besides, I would like to merge both of them before starting to work on the next issue. |
Contributor
Author
|
@josecelano Unlike the other case. I would like to merge this one first. The formatting changes made your code hard to review. |
da2ce7
force-pushed
the
format-world
branch
7 times, most recently
from
58f075e to
a39a0d9
Compare
Contributor
Author
|
ACK a39a0d9 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format all files in the Index Backend.