Fix bug: duplicate slash in torrent announce URL#630
Merged
josecelano merged 5 commits intotorrust:developfrom Jun 11, 2024
Conversation
…unce URL When the tracker is running in private mode the announce URL in the torrent file includes a double slash '/'. For example: http://tracker:7070//KEY This commit adds a failing test. It needed scaffolding to run E2E tests with a tracker running in "private" mode. We have been only running E2E tests for public trackers so far. The new tests is only execute with Sqlite3. It would be easy to run it also for MySQL. It was not cinluded in order to avoid making tests to slow. It requires to start the docker E2E shared environment twice (for public and private tracker configurations).
josecelano
force-pushed
the
628-remove-duplicate-slash-in-tracker-url-inside-to-downloaded-torrent-file
branch
from
9ea88b9 to
96269cd
Compare
Runnint the tracker in private mode the announce URL in the torrent file should be: http://tracker:7070/TRACKER_USER_KEY instead of: http://tracker:7070//TRACKER_USER_KEY
josecelano
force-pushed
the
628-remove-duplicate-slash-in-tracker-url-inside-to-downloaded-torrent-file
branch
from
a933119 to
f0a5006
Compare
Member
Author
|
ACK 784ac54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the tracker runs in private mode the announce URL in the torrent file includes a double slash
/. For example:http://tracker:7070//KEY
Subtasks