Configuration overhaul: rename env vars#598
Merged
josecelano merged 4 commits intotorrust:developfrom May 22, 2024
Merged
Conversation
We should not use specific names (sufix _E2E) for env vars that are not specidif for E2E tests. These env vars are generic enva vars also used in production. They only have different values for the E2E test env. ``` TORRUST_INDEX_E2E_CONFIG -> TORRUST_INDEX_CONFIG TORRUST_INDEX_E2E_TRACKER_API_TOKEN -> TORRUST_INDEX_TRACKER_API_TOKEN TORRUST_INDEX_E2E_AUTH_SECRET_KEY -> TORRUST_INDEX_AUTH_SECRET_KEY TORRUST_INDEX_E2E_PATH_CONFIG -> TORRUST_INDEX_PATH_CONFIG ```
``` TORRUST_INDEX_CONFIG -> TORRUST_INDEX_CONFIG_TOML TORRUST_INDEX_PATH_CONFIG -> TORRUST_INDEX_CONFIG_TOML_PATH TORRUST_INDEX_TRACKER_API_TOKEN -> TORRUST_INDEX_CONFIG_OVERRIDE_TRACKER__TOKEN TORRUST_INDEX_AUTH_SECRET_KEY -> TORRUST_INDEX_CONFIG_OVERRIDE_AUTH__SECRET_KEY ```
josecelano
force-pushed
the
596-configuration-overhaul-rename-env-vars
branch
from
a9e8395 to
97e3634
Compare
Member
Author
|
ACK 97e3634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename env vars:
TORRUST_INDEX_TRACKER_API_TOKEN->TORRUST_INDEX_CONFIG_OVERRIDE_TRACKER__TOKEN.TORRUST_INDEX_CONFIG->TORRUST_INDEX_CONFIG_TOML.