Allow upload torrent with application/octet-stream HTTP header Content-Type#491
Merged
josecelano merged 1 commit intotorrust:developfrom Feb 22, 2024
Conversation
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
HTTP header Content-Type. Some users are having problems uploading torrents becuase the client (browser or other clients) use the HTTP header Contetnt-Type: `application/octet-stream` instead of: `application/x-bittorrent` It seems that the reason is they don't have any application associated to that extension. So it uses the generic binary file mime type. The MIME type can be inferred from the file extension. If the system or application uploading the file has a specific association for .torrent files, it might set the MIME type to application/x-bittorrent. In the absence of such association, it might fall back to the generic application/octet-stream.
josecelano
force-pushed
the
483-request-header-content-type-should-be-applicationx-bittorrent
branch
from
7ab5107 to
8a97b5b
Compare
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
Member
Author
|
ACK 8a97b5b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: torrust/torrust-index-gui#483
Some users are having problems uploading torrents becuase the client (browser or other clients) use the HTTP header Contetnt-Type:
application/octet-streaminstead of:
application/x-bittorrentIt seems that the reason is they don't have any application associated to that extension. So it uses the generic binary file mime type.
The MIME type can be inferred from the file extension. If the system or application uploading the file has a specific association for .torrent files, it might set the MIME type to application/x-bittorrent. In the absence of such an association, it might fall back to the generic application/octet-stream.